Skip to content

optimize: avoid redundant DB call when account matches calling account #11403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

optimize: avoid redundant DB call when account matches calling account #11403

wants to merge 2 commits into from

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Aug 6, 2025

Description

Use Account object from call context when possible

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
optimize: avoid redundant DB call when account matches calling account
931a172 
Use Account object from call context when possible

Signed-off-by: Abhishek Kumar <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.35%. Comparing base (d7b7bd5) to head (095a69e).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...src/main/java/com/cloud/event/UsageEventUtils.java 0.00% 3 Missing ⚠️
...rc/main/java/com/cloud/event/ActionEventUtils.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11403      +/-   ##
============================================
- Coverage     17.35%   17.35%   -0.01%     
+ Complexity    15231    15229       -2     
============================================
  Files          5885     5885              
  Lines        525611   525630      +19     
  Branches      64160    64164       +4     
============================================
- Hits          91224    91217       -7     
- Misses       424090   424115      +25     
- Partials      10297    10298       +1
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.39% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland added this to the 4.21.1 milestone Aug 6, 2025
@shwstppr
fix
095a69e 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 8, 2025

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14579

@sureshanaparti sureshanaparti modified the milestones: 4.21.1, 4.22.0 Aug 8, 2025
@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 8, 2025

@blueorangutan test

@blueorangutan
Copy link

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14047)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11403-t14047-kvm-ol8.zip
Smoke tests completed. 146 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Apache CloudStack 4.22.0
Status: No status
Milestone
4.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shwstppr @blueorangutan @DaanHoogland @sureshanaparti